Skip to content

IGNITE-27700 SQL Calcite: Fix merge filter to scan after trimmed fields#12675

Closed
alex-plekhanov wants to merge 5 commits intoapache:masterfrom
alex-plekhanov:ignite-27700
Closed

IGNITE-27700 SQL Calcite: Fix merge filter to scan after trimmed fields#12675
alex-plekhanov wants to merge 5 commits intoapache:masterfrom
alex-plekhanov:ignite-27700

Conversation

@alex-plekhanov
Copy link
Contributor

@alex-plekhanov alex-plekhanov commented Jan 29, 2026

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

zstan
zstan approved these changes Feb 3, 2026
View reviewed changes
.../java/org/apache/ignite/internal/processors/query/calcite/exec/exp/IgniteScalarFunction.java
private IgniteScalarFunction(Method method, CallImplementor implementor, boolean deterministic) {
super(method, implementor);

this.deterministic = deterministic;
Copy link
Contributor

@zstan zstan Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need mock? tests for such a case ? Can you exted java doc - what unexpected behavior will be raised if this flag missconfigured ?

Copy link
Contributor Author

@alex-plekhanov alex-plekhanov Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test added.
What do you mean by the mock?
JavaDoc for public QuerySqlFunction annotation? I think it's already contains all required information. This annotation used for both query engines, so it's not correct to describe behavour for one of this engine in JavaDoc. Also this behavior can be extended later, for example if Calcite allow to change deterministic flag for SqlUserDefinedFunction class this flag will be processed also by Calcite and we can't control (and desrcibe on any change) all usages of this flag in Calcite code.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
8 New Code Smells (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

zstan pushed a commit that referenced this pull request Feb 4, 2026
@alex-plekhanov @zstan
IGNITE-27700 SQL Calcite: Fix merge filter to scan after trimmed fiel…
28e9b76 
…ds - Fixes #12675.

Signed-off-by: Aleksey Plekhanov <plehanov.alex@gmail.com>
(cherry picked from commit 77987ea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zstan zstan zstan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alex-plekhanov @zstan